Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update html components to mui components including loading #1667

Merged

Conversation

angela-lee1
Copy link
Member

Fixes #1657

What changes did you make and why did you make them?

  • replace HTML components with mui components
  • replace loading svg with mui loading

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image](
Screenshot 2024-06-12 at 5 29 21 PM
)

Visuals after changes are applied

![image](
Screenshot 2024-06-12 at 5 35 54 PM
)

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b awlFCCamp-update-HTMLtoMUI-donutchartloading development
git pull https://github.com/awlFCCamp/VRMS.git update-HTMLtoMUI-donutchartloading

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

Great work on using the CircularPorgress componnet :)

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Nice work!

@jbubar jbubar merged commit 5d8f9a1 into hackforla:development Jun 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/admin/donutChartLoading.js
3 participants